-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate Detection ported from DSpace CRIS 7 Angular #1732
Duplicate Detection ported from DSpace CRIS 7 Angular #1732
Conversation
This pull request introduces 1 alert when merging 0a193b8 into ea67a15 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 9bbbbfa into f6d2014 - view on LGTM.com new alerts:
|
I solved the display issue that I had noted in my first PR description. Describing my fix below for reviewers' attention: There is an action + effect combo “CleanDetectDuplicateSection”. It’s only dispatched when the I modified the |
This pull request introduces 1 alert when merging aa4bbd1 into f6d2014 - view on LGTM.com new alerts:
|
aa4bbd1
to
13d17aa
Compare
This pull request introduces 1 alert when merging 13d17aa into c876055 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 5ab3acd into dc4b4ff - view on LGTM.com new alerts:
|
Hi @kshepherd, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
5ab3acd
to
f014d71
Compare
593f8fd
to
8b8c630
Compare
Thanks @kshepherd! Like @benbosman on the backend, I'm not assigned as a reviewer on this PR, but I gave it a quick test. A few comments and questions:
|
We are willing to follow this up if it is clear who and when it is being reviewed. We rebased and fixed this PR several times. We would do this one more time if there is a concrete plan how this is being reviewed. We will not rebase again and again until it is clear who and when this will be reviewed. Please ping us or contact us otherwise if you are interested in reviewing it. |
Hi @kshepherd, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
We took a a new simpler and clean approach. Closing this in favor for #2749 |
This pull request ports the Duplicate Detection framework from DSpace CRIS 7 into DSpace.
Attribution: Ported from DSpace-CRIS and extended by The Library Code with support of Technische Universität Berlin
DSpace Backend PR: DSpace/DSpace#8415
REST Contract PR: TBD
One outstanding issue
For a new submission, the default behaviour when no matches are found should be to keep the section hidden, but instead, the default message indicates that decisions are all registered.
Fixed, see comment #1732 (comment)
To test
Notes for PR reviewers
Notes for 4Science devs (regarding changes from CRIS)
As I’ve added an authorization check (configurable, enabled by default) so that the user needs read access to each item in the potential matches list, I manually disabled it for some integration tests and leave it for others, and explicitly test it in a new integration test
I’ve added javadoc and most is pretty straightforward but please correct me if I misunderstood terms such as ‘fake', ‘reader’
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!